From fe198c960fb85850acbe819e12ca465cd6091bc3 Mon Sep 17 00:00:00 2001
From: HelionSmoker <82761116+HelionSmoker@users.noreply.github.com>
Date: Sun, 12 Feb 2023 12:24:10 +0200
Subject: [PATCH] Rewrite sb-forecast

---
 .local/bin/statusbar/sb-forecast | 52 ++++++++++++++++++++------------
 1 file changed, 33 insertions(+), 19 deletions(-)

diff --git a/.local/bin/statusbar/sb-forecast b/.local/bin/statusbar/sb-forecast
index 9744ea4..59f0497 100755
--- a/.local/bin/statusbar/sb-forecast
+++ b/.local/bin/statusbar/sb-forecast
@@ -1,24 +1,41 @@
 #!/bin/sh
 
-# Displays todays precipication chance (☔) and daily low (🥶) and high (🌞).
+# Displays today's precipication chance (☔), and daily low (🥶) and high (🌞).
 # Usually intended for the statusbar.
 
-# If we have internet, get a weather report from wttr.in and store it locally.
-# You could set up a shell alias to view the full file in a pager in the
-# terminal if desired. This function will only be run once a day when needed.
-weatherreport="${XDG_CACHE_HOME:-$HOME/.cache}/weatherreport"
-getforecast() { curl -sf "wttr.in/$LOCATION" > "$weatherreport" || exit 1 ;}
+weather_report="${XDG_CACHE_HOME:-$HOME/.cache}/weatherreport"
 
-# Some very particular and terse stream manipulation. We get the maximum
-# precipitation chance and the daily high and low from the downloaded file and
-# display them with coresponding emojis.
-showweather() { printf "%s" "$(sed '16q;d' "$weatherreport" |
-	grep -wo "[0-9]*%" | sort -rn | sed "s/^/☔/g;1q" | tr -d '\n')"
-sed '13q;d' "$weatherreport" | grep -o "m\\([-+]\\)*[0-9]\\+" | sed 's/+//g' | sort -n -t 'm' -k 2n | sed -e 1b -e '$!d' | tr '\n|m' ' ' | awk '{print " 🥶" $1 "°","🌞" $2 "°"}' ;}
+# Get a weather report from 'wttr.in' and save it locally.
+get_forecast() { curl -sf "wttr.in/$LOCATION" > "$weather_report" || exit 1; }
+
+# Forecast should be updated only once a day
+check_forecast() {
+	[ -s "$weather_report" ] && [ "$(stat -c %y "$weather_report" 2>/dev/null |
+		cut -d' ' -f1)" = "$(date '+%Y-%m-%d')" ]
+}
+
+get_precip_chance() {
+	sed '16q;d' "$weather_report" | # Extract line 16 from file
+		grep -wo "[0-9]*%" |           # Find a sequence of digits followed by '%'
+		sort -rn |                     # Sort in descending order
+		head -1q                       # Extract first line
+}
+
+get_daily_high_low() {
+	sed '13q;d' "$weather_report" |   # Extract line 13 from file
+		grep -o "m\\([-+]\\)*[0-9]\\+" | # Find temperatures in the format "m<signed number>"
+		sed 's/[+m]//g' |                # Remove '+' and 'm'
+		sort -n -k 2n |                  # Sort in ascending order
+		sed -e 1b -e '$!d'               # Extract the first and last lines
+}
+
+show_weather() {
+	printf "☔%s 🥶%s° 🌞%s°\n" "$(get_precip_chance)" $(get_daily_high_low)
+}
 
 case $BLOCK_BUTTON in
-	1) setsid -f "$TERMINAL" -e less -Srf "$weatherreport" ;;
-	2) getforecast && showweather ;;
+	1) setsid -f "$TERMINAL" -e less -Srf "$weather_report" ;;
+	2) get_forecast && show_weather ;;
 	3) notify-send "🌈 Weather module" "\- Left click for full forecast.
 - Middle click to update forecast.
 ☔: Chance of rain/snow
@@ -27,9 +44,6 @@ case $BLOCK_BUTTON in
 	6) "$TERMINAL" -e "$EDITOR" "$0" ;;
 esac
 
-# The test if our forcecast is updated to the day. If it isn't download a new
-# weather report from wttr.in with the above function.
-[ -s "$weatherreport" ] && [ "$(stat -c %y "$weatherreport" 2>/dev/null | cut -d' ' -f1)" = "$(date '+%Y-%m-%d')" ] ||
-	getforecast
+check_forecast || get_forecast
 
-showweather
+show_weather