refactor

README.md

@@ -55,7 +55,7 @@ Munera is a companion for managing expenses efficiently and effortlessly, whethe
     - If possible, the calculations should take into account the different currencies
 
 5. **Events**
-    - ~~Options to create events in which to put expenses (vacations, congress, etc)~~
+    - ~~Options to create events in which to put expenses (vacations, congress, etc.)~~
     - ~~Each event has a number of people connected to it, expenses can be added to these people~~
     - A reports tells which people need to give/take money to which people in order to be even
 
@@ -69,8 +69,8 @@ Munera is a companion for managing expenses efficiently and effortlessly, whethe
 
 ## Known Issues
 
-- PeopleVIew dosent refresh after an edit operation anymore
+- PeopleVIew doesn't refresh after an edit operation anymore
 - Form still needs more validation when empty, some entities can be created with all null values, even the ones that have constraints throw SQL errors, they need to be gracefully handled.
 - Errors need to be caught and handled
 - Graphs still need ~~a lot of~~ **some** improvements
-- ~~ExpenseView dosent refresh after an edit operation anymore~~
+- ~~ExpenseView doesn't refresh after an edit operation anymore~~

src/main/java/com/application/munera/data/Person.java

@@ -54,10 +54,9 @@ public class Person extends AbstractEntity {
         if (obj == this) {
             return true;
         }
-        if (!(obj instanceof Person)) {
+        if (!(obj instanceof Person other)) {
             return false;
         }
-        Person other = (Person) obj;
         return Objects.equals(firstName, other.firstName) &&
                 Objects.equals(lastName, other.lastName) &&
                 Objects.equals(email, other.email);

src/main/java/com/application/munera/views/login/LoginView.java

@@ -36,9 +36,7 @@ public class LoginView extends VerticalLayout implements BeforeEnterObserver {
         login.setI18n(i18n);
 
         // Add a listener for the Forgot password button
-        login.addForgotPasswordListener(event -> {
+        login.addForgotPasswordListener(event -> Notification.show("Tough shit, feature aint ready yet!", 3000, Notification.Position.BOTTOM_CENTER));
-            Notification.show("Tough shit, feature aint ready yet!", 3000, Notification.Position.BOTTOM_CENTER);
-        });
 
         add(new H1("Munera"), new H2("An expense tracking application"), login);
     }

src/main/java/com/application/munera/views/people/PeopleView.java

@@ -146,7 +146,7 @@ public class PeopleView extends Div implements BeforeEnterObserver {
     }
 
     private String getNodeCost(Object node) {
-        if (node instanceof Person) return this.personService.calculateNetBalance((Person) node).toString() + " €";
+        if (node instanceof Person) return this.personService.calculateNetBalance((Person) node) + " €";
         else if (node instanceof Expense) return ((Expense) node).getCost().toString() + " €";
         return "";
     }