NapoleonDynamite/LARBS
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix the "tap-to-click" enabler

Browse source 
1. We need them quotes (`"`) where they are specified in the `40-libinput.conf` file, but if you use `echo` and echo surround the output string itself with the double quotes (`"`), the ones inside it will get removed. fixed.

pretty lucky that I just happened to be a part of the convo in https://github.com/LukeSmithxyz/LARBS/issues/118 to get a notification & thus notice & try out 1d8b03595a - Xorg reported an error and couldn't launch i3, so here we are:D

2. (misc since it doesn't matter as much here but anyhow) `echo` shouldn't be used in any scripts anyway because it's unpredictable, and `printf` should be preferred (imo, anyway. Just mind that you there's no extra newline so if you need one/expected one from echo - add it yourself):

```sh
# unpredictable echo (with newline by default, though not always)
$ echo "omg larbs so kewl"
omg larbs so kewl
$
```

```sh
# predictable printf without a newline by default
$ printf "omg larbs so kewl"
omg larbs so kewl $
```

```sh
# predictable printf with a newline because you said so
$ printf "omg larbs so kewl\n"
omg larbs so kewl
$
```

take care!
This commit is contained in:
Kipras Melnikovas 2020-10-12 19:35:19 +03:00 committed by GitHub
parent 1d8b03595a
commit cd5b32c591
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
larbs.sh
View file

@ -220,14 +220,14 @@ sudo -u "$name" mkdir -p "/home/$name/.cache/zsh/"
dbus-uuidgen > /var/lib/dbus/machine-id dbus-uuidgen > /var/lib/dbus/machine-id
# Tap to click # Tap to click
[ ! -f /etc/X11/xorg.conf.d/40-libinput.conf ] && echo "Section "InputClass" [ ! -f /etc/X11/xorg.conf.d/40-libinput.conf ] && printf 'Section "InputClass"
Identifier "libinput touchpad catchall" Identifier "libinput touchpad catchall"
MatchIsTouchpad "on" MatchIsTouchpad "on"
MatchDevicePath "/dev/input/event*" MatchDevicePath "/dev/input/event*"
Driver "libinput" Driver "libinput"
# Enable left mouse button by tapping # Enable left mouse button by tapping
Option "Tapping" "on" Option "Tapping" "on"
EndSection" > /etc/X11/xorg.conf.d/40-libinput.conf EndSection' > /etc/X11/xorg.conf.d/40-libinput.conf
# Fix fluidsynth/pulseaudio issue. # Fix fluidsynth/pulseaudio issue.
grep -q "OTHER_OPTS='-a pulseaudio -m alsa_seq -r 48000'" /etc/conf.d/fluidsynth || grep -q "OTHER_OPTS='-a pulseaudio -m alsa_seq -r 48000'" /etc/conf.d/fluidsynth ||